for AWS Aurora users and when using a DB Reader: new INI setting to enable aurora read replica read committed for fixing purge lag performance issue #17718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Jun 29, 2021
| @@ -184,6 +184,10 @@ public static function createReaderDatabaseObject($dbConfig = null) | |||
|
|
|||
| $db = @Adapter::factory($dbConfig['adapter'], $dbConfig); | |||
|
|
|||
| if (!empty($dbConfig['aurora_readonly_read_committed'])) { | |||
There was a problem hiding this comment.
fyi we might still want to update global.ini.php here maybe @justinvelluppillai @diosmosis ?
There was a problem hiding this comment.
Do we want to document the setting?
There was a problem hiding this comment.
I reckon it be good. Even if it's just useful mostly for us but then other devs will know what it's about.
There was a problem hiding this comment.
I'll document and create a new pull request to add the global.ini.php update
10 tasks
mattab
changed the title
mattab
added
the
c: Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allows enabling aurora read replica read committed
Review