Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log for the current record being aggregated #17716

Merged
merged 1 commit into from Jun 28, 2021
Merged

Add log for the current record being aggregated #17716

merged 1 commit into from Jun 28, 2021

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jun 28, 2021
@diosmosis diosmosis added this to the 4.4.0 milestone Jun 28, 2021
sgiehl
sgiehl approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jun 28, 2021
@diosmosis diosmosis merged commit 5a68eed into 4.x-dev Jun 28, 2021
@diosmosis diosmosis deleted the add-quick-record-aggregate-log branch June 28, 2021 19:22
@mattab mattab changed the title Add log for the current record being aggregated. Add log for the current record being aggregated Jul 27, 2021
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @mattab