Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use team mention for github stale actions #17705

Merged
merged 1 commit into from Jun 24, 2021
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 24, 2021

Description:

use @matomo-org/core-reviewers to make it easier to update the list of mentioned people

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 24, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone Jun 24, 2021
@justinvelluppillai
Copy link
Contributor

I approved the changes but don't have merging permissions yet

@tsteur
Copy link
Member

tsteur commented Jun 24, 2021

@justinvelluppillai sorry about that. I added the new core-reviewers team to have merge permissions

@justinvelluppillai justinvelluppillai merged commit f7abdd9 into 4.x-dev Jun 24, 2021
@justinvelluppillai justinvelluppillai deleted the reviewers branch June 24, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants