Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing row limit when hierarchy is expanded #17704

Merged
merged 2 commits into from Jun 25, 2021
Merged

Allow changing row limit when hierarchy is expanded #17704

merged 2 commits into from Jun 25, 2021

Conversation

justinvelluppillai
Copy link
Contributor

Description:

Fixes #17628

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 24, 2021
@justinvelluppillai justinvelluppillai added this to the 4.4.0 milestone Jun 24, 2021
sgiehl
sgiehl approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinvelluppillai did you have any reason for creating the PR as draft, but adding a needs review label?
Had a look nevertheless and it would be fine to merge.

@justinvelluppillai justinvelluppillai marked this pull request as ready for review June 24, 2021 19:27
@justinvelluppillai
Copy link
Contributor Author

I wanted to let the tests pass before publishing. I'll leave the Needs Review label off in future.

Still sorting out my processes a bit so keep the comments coming if I do anything strange 👍

@justinvelluppillai justinvelluppillai merged commit 438f518 into 4.x-dev Jun 25, 2021
@justinvelluppillai justinvelluppillai deleted the 17628-show-rows-to-display branch June 25, 2021 03:49
@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

"Rows to display" cannot be changed if a row is expanded
2 participants
@justinvelluppillai @sgiehl