@justinvelluppillai opened this Pull Request on June 24th 2021 Contributor

Description:

Fixes #17628

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@justinvelluppillai commented on June 24th 2021 Contributor

I wanted to let the tests pass before publishing. I'll leave the Needs Review label off in future.

Still sorting out my processes a bit so keep the comments coming if I do anything strange 👍

This Pull Request was closed on June 25th 2021
Powered by GitHub Issue Mirror