Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web cron archive - allow POST'd token_auth #17703

Merged
merged 2 commits into from Jun 25, 2021
Merged

Web cron archive - allow POST'd token_auth #17703

merged 2 commits into from Jun 25, 2021

Conversation

justinvelluppillai
Copy link
Contributor

Description:

Fixes #14190

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 23, 2021
@justinvelluppillai justinvelluppillai added this to the 4.4.0 milestone Jun 23, 2021
sgiehl
sgiehl reviewed Jun 23, 2021
View reviewed changes
misc/cron/archive.php Outdated Show resolved Hide resolved
@justinvelluppillai @sgiehl
Explicitly check for empty string
1f53ebb 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@justinvelluppillai justinvelluppillai marked this pull request as ready for review June 24, 2021 00:37
@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Jun 24, 2021
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jun 25, 2021
@sgiehl sgiehl merged commit 053ff36 into 4.x-dev Jun 25, 2021
@sgiehl sgiehl deleted the 14190-archive-authtoken-post branch June 25, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Allow web cron via POST
2 participants
@justinvelluppillai @sgiehl