Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notify list for github stale actions #17702

Merged
merged 1 commit into from Jun 23, 2021
Merged

Update notify list for github stale actions #17702

merged 1 commit into from Jun 23, 2021

Conversation

justinvelluppillai
Copy link
Contributor

Description:

Add justinvelluppillai and remove flamisz to stale issue/PR notification

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 23, 2021
@justinvelluppillai
Copy link
Contributor Author

Maybe later we can create a stale notifications team to make this easier but updating individuals for now

@sgiehl sgiehl added this to the 4.4.0 milestone Jun 23, 2021
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jun 23, 2021
@sgiehl sgiehl merged commit c9df572 into 4.x-dev Jun 23, 2021
@sgiehl sgiehl deleted the update-action-notify-list branch June 23, 2021 07:19
@Findus23
Copy link
Member

Findus23 commented Jun 23, 2021 •
edited

Wouldn't it be easier to just ping a team like in @matomo-org/core-team and then just update the people on the team as needed?

For this we would either need to change the core-team list or create a new team.

@sgiehl
Copy link
Member

sgiehl commented Jun 23, 2021

as @justinvelluppillai also mentioned. But would be good to have a new team for that, so not all core team members are mentioned.
@tsteur @mattab could you maybe create a new team for that?

@tsteur
Copy link
Member

tsteur commented Jun 23, 2021 •
edited

@sgiehl created a team matomo-org/core-reviewers

@Findus23
Copy link
Member

@sgiehl, @justinvelluppillai Sorry, I totally missed that message above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinvelluppillai @Findus23 @sgiehl @tsteur