New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds some more tests for log importer #17700
Conversation
Note: One of the new tests is currently failing due to matomo-org/matomo-log-analytics#317 |
Nice test addition 👍! Would it also be good to have a replay log for the test? There we can also include strange encoding for the action_name. Also think it might be a good idea to regenerate OmniFixture at some point after this so we can see how the UI tests respond. What do you think? |
@diosmosis matomo/tests/PHPUnit/Fixtures/ManySitesImportedLogs.php Lines 278 to 287 in 375dd9f
And the added tests won't change the OmniFixture, as the visits are imported within single tests and not within a Fixture. |
I meant adding the encoding to the reply logs so an encoded value can be added to action_name for tests.
Would it be better if it was within a fixture so OmniFixture would pick it up? It might be useful to see if those types of encoded values breaks anything in the UI. |
@diosmosis I won't change anything here for now, as there is more important stuff to work on. Maybe you can have a quick final look and merge the additional tests if they are fine. We can consider changing them later as well. |
👍 I'll make a new issue for adding encoded data to fixtures |
Description:
Review