Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about custom segments in archiving setting #17698

Merged
merged 3 commits into from Jun 27, 2021
Merged

Add info about custom segments in archiving setting #17698

merged 3 commits into from Jun 27, 2021

Conversation

justinvelluppillai
Copy link
Contributor

… triggered archiving will not prevent processing of archives when Custom Segments are used, if config browser_archiving_disabled_enforce=0

Description:

Fixes #17479

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@justinvelluppillai
UI improvement - improve message to indicate that turning off browser…
65dfadc 
… triggered archiving will not prevent processing of archives when Custom Segments are used, if config browser_archiving_disabled_enforce=0
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 21, 2021
@justinvelluppillai justinvelluppillai added this to the 4.4.0 milestone Jun 21, 2021
@justinvelluppillai justinvelluppillai changed the title UI improvement - improve message to indicate that turning off browser… Add info about custom segments in archiving setting Jun 21, 2021
@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Jun 22, 2021
@justinvelluppillai justinvelluppillai marked this pull request as ready for review June 22, 2021 03:58
@diosmosis diosmosis merged commit 89abb4b into 4.x-dev Jun 27, 2021
@diosmosis diosmosis deleted the 17479-archiving-off-message branch June 27, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

UI: Disabling browser archiving is not clear it does not disable browser archiving for segment
3 participants
@justinvelluppillai @sgiehl @diosmosis