@Seb35 opened this Pull Request on June 18th 2021 Contributor

Description:

Issue: #12217 - in the system check page, filesystems like btrfs subvolumes are wrongly recognised as NFS.

NFS filesystems are identified as 'nfs' or 'nfs4' by df -T, so the added condition tests the existence of ' nfs'.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@Seb35 commented on June 18th 2021 Contributor

I tested on my Matomo installation where the directory tmp is a btrfs subvolume (and tmp/sessions is inside): the check now passes.

@github-actions[bot] commented on June 26th 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@Seb35 commented on June 28th 2021 Contributor

I did the requested change, it is now more robust.

@diosmosis commented on June 29th 2021 Member

@Seb35 I tested locally and it works well, thanks again for creating this PR and contributing some code! We certainly appreciate the effort.

This Pull Request was closed on June 29th 2021
Powered by GitHub Issue Mirror