Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue "Call to a member function getMainUrl() on null" in permission checks in siteWithoutData method #17694

Merged
merged 1 commit into from Jun 24, 2021
Merged

Fix issue "Call to a member function getMainUrl() on null" in permission checks in siteWithoutData method #17694

merged 1 commit into from Jun 24, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 18, 2021

Description:

fixes L3-112

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Jun 18, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone Jun 18, 2021
@sgiehl sgiehl requested a review from tsteur June 23, 2021 07:51
@sgiehl sgiehl merged commit bd0a5e7 into 4.x-dev Jun 24, 2021
@sgiehl sgiehl deleted the l3-112 branch June 24, 2021 07:52
@mattab mattab changed the title Fix permission checks for siteWithoutData methods Fix issue "Call to a member function getMainUrl() on null" in permission checks in siteWithoutData method Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur