@Findus23 opened this Pull Request on June 18th 2021 Member

see https://github.com/matomo-org/matomo/issues/17686

$ids can be null because of

https://github.com/matomo-org/matomo/blob/1fcc10569378263775a1f8a3e2429406da9423ce/plugins/CoreConsole/Commands/CoreArchiver.php#L44

https://github.com/matomo-org/matomo/blob/1fcc10569378263775a1f8a3e2429406da9423ce/plugins/CoreConsole/Commands/CoreArchiver.php#L68-L71

when no command line arg is passed.

I'm not completely sure if this is the correct fix, but it seems reasonable to me.

Also changed a similar case with $segmentIds.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on June 18th 2021
Powered by GitHub Issue Mirror