@Findus23 opened this Pull Request on June 17th 2021 Member

refs #17686

fixes

WARNING [2021-06-17 22:27:06] 321855 /home/lukas/public_html/matomophp8/libs/Zend/Db/Statement/Pdo.php(257): Deprecated - PDOStatement::fetch(): Passing null to parameter #2 ($cursorOrientation) of type int is deprecated - Matomo 4.4.0-b1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already)
WARNING [2021-06-17 22:28:30] 322336 /home/lukas/public_html/matomophp8/libs/Zend/Db/Statement/Pdo.php(257): Deprecated - PDOStatement::fetch(): Passing null to parameter #3 ($cursorOffset) of type int is deprecated - Matomo 4.4.0-b1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already)

in php 8.1

defaults were taken from https://www.php.net/manual/de/pdostatement.fetch.php (the style one didn't output an error, but I changed it nevertheless)

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on June 17th 2021 Member

@Findus23 FETCH_DEFAULT does not appear to be defined until 8.0.7. We'll need to try another approach.

@sgiehl commented on June 18th 2021 Member

As the default should be FETCH_BOTH, why not using this?

@sgiehl commented on June 18th 2021 Member

there are quite a lot tests failing not sure what's causing it...

@github-actions[bot] commented on June 26th 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@Findus23 commented on June 26th 2021 Member

@matomo-org/core-reviewers, It seems like the github actions bot is not able to ping the team.
Really weird.

Seems like I also can't and it is not in the list of suggestions. Maybe there is a setting in the team that needs to be changed.

@github-actions[bot] commented on July 5th 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on July 14th 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on July 22nd 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@sgiehl commented on July 22nd 2021 Member

I've changed the code slightly. The default value for the first parameter was actually not needed, as it is set within the method. Should be ready for a final review.

@github-actions[bot] commented on July 30th 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

Powered by GitHub Issue Mirror