New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP 8.1 compatibility] don't pass null to PDOStatement::fetch() #17689
Conversation
@Findus23 |
As the default should be |
there are quite a lot tests failing not sure what's causing it... |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
@matomo-org/core-reviewers, It seems like the github actions bot is not able to ping the team. Seems like I also can't and it is not in the list of suggestions. Maybe there is a setting in the team that needs to be changed. |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
257610b
to
bef0396
Compare
it's set in the method if null was given
I've changed the code slightly. The default value for the first parameter was actually not needed, as it is set within the method. Should be ready for a final review. |
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
refs #17686
fixes
in php 8.1
defaults were taken from https://www.php.net/manual/de/pdostatement.fetch.php (the style one didn't output an error, but I changed it nevertheless)
Review