Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type attribute from tracking code #17685

Merged
merged 13 commits into from Jun 25, 2021
Merged

Remove type attribute from tracking code #17685

merged 13 commits into from Jun 25, 2021

Conversation

justinvelluppillai
Copy link
Contributor

@justinvelluppillai justinvelluppillai commented Jun 17, 2021 •
edited by Findus23

fixes #17281

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Jun 17, 2021
@justinvelluppillai justinvelluppillai added this to the 4.4.0 milestone Jun 17, 2021
@sgiehl
Copy link
Member

sgiehl commented Jun 17, 2021

Wasn't the original issue (also) about TagManager? Guess it would need to be adjusted there too:
https://github.com/matomo-org/tag-manager/blob/6ceadc8bbeb9dfbf107d2a2e09d15a8d77cd3f7e/Context/WebContext.php#L244-L253

Also there are a couple of tests that started failing and needs to be updated

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 18, 2021
@justinvelluppillai justinvelluppillai changed the title Remove redundant type="text/javascript" from matomo tracking code, se… Remove type attribute from tracking code Jun 22, 2021
sgiehl
sgiehl approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged in the latest 4.x-dev changes. If tests are passing it should be good to merge now.

@sgiehl sgiehl merged commit ce3e9f9 into 4.x-dev Jun 25, 2021
@sgiehl sgiehl deleted the 17281-remove-script-type-attr branch June 25, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@tsteur tsteur Awaiting requested review from tsteur

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

JS Tracking code should validate with the W3C validator
2 participants
@justinvelluppillai @sgiehl