@justinvelluppillai opened this Pull Request on June 17th 2021 Contributor

fixes #17281

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on June 17th 2021 Member

Wasn't the original issue (also) about TagManager? Guess it would need to be adjusted there too:
https://github.com/matomo-org/tag-manager/blob/6ceadc8bbeb9dfbf107d2a2e09d15a8d77cd3f7e/Context/WebContext.php#L244-L253

Also there are a couple of tests that started failing and needs to be updated

This Pull Request was closed on June 25th 2021
Powered by GitHub Issue Mirror