Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for setting max_execution_time = -1, see #17585 #17684

Merged
merged 2 commits into from Jun 17, 2021

Conversation

justinvelluppillai
Copy link
Contributor

@justinvelluppillai justinvelluppillai commented Jun 17, 2021

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@justinvelluppillai justinvelluppillai added the Needs Review PRs that need a code review label Jun 17, 2021
@justinvelluppillai justinvelluppillai added this to the 4.4.0 milestone Jun 17, 2021
@sgiehl
Copy link
Member

sgiehl commented Jun 17, 2021

@justinvelluppillai Would be good to mention the issue a PR is going to fix in the PR description like fixes #17585. Github will then automatically close the issue when the PR gets merged.

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will update the failing UI tests and merge.

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jun 17, 2021
@sgiehl sgiehl merged commit 0c38597 into 4.x-dev Jun 17, 2021
@sgiehl sgiehl deleted the 17585-max-execution-time-values branch June 17, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System Check showing warning when max_execution_time is set to -1 in PHP.ini
2 participants