@justinvelluppillai opened this Pull Request on June 17th 2021 Contributor

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • [x] Functional review done
  • [x] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done see checklist
  • [x] Code review done
  • [x] Tests were added if useful/possible
  • [x] Reviewed for breaking changes
  • [x] Developer changelog updated if needed
  • [x] Documentation added if needed
  • [x] Existing documentation updated if needed
@sgiehl commented on June 17th 2021 Member

@justinvelluppillai Would be good to mention the issue a PR is going to fix in the PR description like fixes <a href='/17585'>#17585</a>. Github will then automatically close the issue when the PR gets merged.

This Pull Request was closed on June 17th 2021
Powered by GitHub Issue Mirror