@diosmosis opened this Pull Request on June 17th 2021 Member

Description:

Changes:

  • allow option to disable allowed host check since trackingspamprevention makes a request to amazonaws
  • bound parameters can be a single string rather than an array
  • disable testdox and add build message output to enable it if the build hangs

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on June 17th 2021 Member

Also note: after merging, TrackingSpamPrevention's minimum required matomo will need to be updated

@sgiehl commented on June 17th 2021 Member

The problem is that most tests are failing. Guess it might make more sense
to move that to the console command that runs the tests maybe

@diosmosis commented on June 17th 2021 Member

@sgiehl I see, nevermind, phpstorm gave me the wrong bootstrap file. It should be in the test's bootstrap.php.

This Pull Request was closed on June 18th 2021
Powered by GitHub Issue Mirror