Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves detection of local hostnames #17681

Merged
merged 1 commit into from Jun 16, 2021
Merged

Improves detection of local hostnames #17681

merged 1 commit into from Jun 16, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 16, 2021

Description:

According to https://github.com/swisskyrepo/PayloadsAllTheThings/blob/master/Server%20Side%20Request%20Forgery/README.md#bypassing-filters there are various alternative notations that end up in requests to localhost.

The list might still not be complete, but it should cover most of them.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jun 16, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone Jun 16, 2021
@diosmosis diosmosis merged commit 5e4ac63 into 4.x-dev Jun 16, 2021
@diosmosis diosmosis deleted the localhost branch June 16, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants