Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip in rowevolution popover title #17680

Merged
merged 3 commits into from Jun 17, 2021
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 16, 2021

Description:

The popover title actually does not need any <wbr> tags, as it's only displayed on one line and shortened using ellipsis.

fixes #17679

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 16, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone Jun 16, 2021
@diosmosis
Copy link
Member

Looks like one of the screenshots isn't in LFS, otherwise good to merge.

@sgiehl
Copy link
Member Author

sgiehl commented Jun 17, 2021

Seems the screenshots of CustomDimensions plugin never had been on git lfs. will move them there

@sgiehl sgiehl merged commit fbd68bd into 4.x-dev Jun 17, 2021
@sgiehl sgiehl deleted the rowevolutionpopovertooltip branch June 17, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<wbr> can be displayed in tooltip in "Row Evolution"
2 participants