@sgiehl opened this Pull Request on June 16th 2021 Member

Description:

The popover title actually does not need any <wbr> tags, as it's only displayed on one line and shortened using ellipsis.

fixes #17679

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on June 16th 2021 Member

Looks like one of the screenshots isn't in LFS, otherwise good to merge.

@sgiehl commented on June 17th 2021 Member

Seems the screenshots of CustomDimensions plugin never had been on git lfs. will move them there

This Pull Request was closed on June 17th 2021
Powered by GitHub Issue Mirror