Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameters of UsersManager.addUser.end event #17678

Merged
merged 1 commit into from Jun 16, 2021
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 16, 2021

Description:

The event UsersManager.addUser.end used to receive the email address of the newly created user, but now receives an email object.

regression from #17531

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jun 16, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone Jun 16, 2021
@diosmosis diosmosis merged commit 3243c14 into 4.x-dev Jun 16, 2021
@diosmosis diosmosis deleted the fixeventparam branch June 16, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants