Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check bound parameters for Date instances if in development mode #17676

Merged
merged 1 commit into from Jun 16, 2021
Merged

check bound parameters for Date instances if in development mode #17676

merged 1 commit into from Jun 16, 2021

Conversation

diosmosis
Copy link
Member

Description:

Quick check to avoid a problem while developing.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 16, 2021
@diosmosis diosmosis added this to the 4.4.0 milestone Jun 16, 2021
sgiehl
sgiehl approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have any such problem yet. But won't hurt to have it I guess 😉

@diosmosis diosmosis merged commit c866aff into 4.x-dev Jun 16, 2021
@diosmosis diosmosis deleted the date-warning branch June 16, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl