Make sure overlay API requests send force_api_session as POST param #17675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the JS tracker we try to detect whether we are in an Overlay iframe by checking the HTTP referrer. If the referrer is from a specific Overlay controller action, then we know we're in Overlay.
The regex for parsing the segment parameter in this detection logic is incorrect. In it, we end up matching the segment parameter, plus everything after it. For example, in
&segment=&token_auth=...&force_api_session=1
we match&token_auth=...&force_api_session=1
, and assume this is the segment.This is passed on to the Overlay/client.js code which appends it to every API request it makes, assuming that it's the segment. These parameters passed in the URL breaks the force_api_session code, since in the browser we make POST requests (so the token_auth is not saved in the browser cache), and server side we do not allow force_api_session to be used in $_GET if using a POST request.
Fixing this in two ways:
Review