Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing hardcoded strings and adding new translation strings for "We… #17673

Merged
merged 1 commit into from Jun 14, 2021
Merged

Removing hardcoded strings and adding new translation strings for "We… #17673

merged 1 commit into from Jun 14, 2021

Conversation

justinvelluppillai
Copy link
Contributor

…bsite updated" and "Website created" text

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 14, 2021
@justinvelluppillai justinvelluppillai added this to the 4.5.0 milestone Jun 14, 2021
@diosmosis diosmosis merged commit f9fb5b5 into 4.x-dev Jun 14, 2021
@diosmosis diosmosis deleted the 17591-adding-translation branch June 14, 2021 22:30
@diosmosis diosmosis modified the milestones: 4.5.0, 4.4.0 Jun 14, 2021
@Findus23 Findus23 mentioned this pull request Jun 14, 2021
Closed
@Findus23 Findus23 linked an issue Jun 14, 2021 that may be closed by this pull request
DE-Translation missed, when website was updated #17591
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

DE-Translation missed, when website was updated
2 participants
@justinvelluppillai @diosmosis