Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Drupal or WebFlow Matomo FAQ when the website is detected to use it #17671

Merged
merged 4 commits into from Jun 15, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 14, 2021

Description:

Besides wordpress and other already detected site types, Matomo will now also detect pages based on Drupal and WebFlow and will automatically link to the correct guide how to integrate Matomo there.

In addition requests to localhost and plane IPs will be avoided for site detection and there is a new DI config for completely blocking certain hosts for requests through Matomo's Http class.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jun 14, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone Jun 14, 2021
@diosmosis diosmosis merged commit f839cb9 into 4.x-dev Jun 15, 2021
@diosmosis diosmosis deleted the sitetype branch June 15, 2021 16:08
@mattab mattab changed the title Improvements to site type detection (added Drupal and WebFlow) Link to Drupal or WebFlow documentation when the website is detected to use it Jul 27, 2021
@mattab mattab changed the title Link to Drupal or WebFlow documentation when the website is detected to use it Link to Drupal or WebFlow Matomo FAQ when the website is detected to use it Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants