Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action for updating puppeteer #17667

Open
diosmosis opened this issue Jun 12, 2021 · 0 comments
Open

github action for updating puppeteer #17667

diosmosis opened this issue Jun 12, 2021 · 0 comments
Labels
Better processes Indicates an issue is about improving how we work. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.

Comments

@diosmosis
Copy link
Member

Summary

Currently the version of puppeteer we use during UI tests is never updated, because doing so changes every screenshot and each change must be manually approved. To semi-automate this so we can keep the version up to date, we could create a github action that does the following:

  • update puppeteer in a pull request
  • wait for travis-ci build to run
  • copy over every changed screenshot and push them

The action would run once a month and would just create a PR. Then an individual could go through each image and make sure the changes are ok, and merge if so.

@diosmosis diosmosis added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Better processes Indicates an issue is about improving how we work. labels Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Better processes Indicates an issue is about improving how we work. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Development

No branches or pull requests

2 participants