Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use correct event handler in login plugin #17666

Merged
merged 1 commit into from Jun 14, 2021
Merged

use correct event handler in login plugin #17666

merged 1 commit into from Jun 14, 2021

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label Jun 12, 2021
@diosmosis diosmosis added this to the 4.4.0 milestone Jun 12, 2021
@sgiehl sgiehl merged commit 38353c8 into 4.x-dev Jun 14, 2021
@sgiehl sgiehl deleted the event-handler-fix branch June 14, 2021 07:04
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @mattab @sgiehl