Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable logme functionality by default #17665

Merged
merged 2 commits into from Jun 14, 2021
Merged

Disable logme functionality by default #17665

merged 2 commits into from Jun 14, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 11, 2021

Description:

Logme functionality will be disabled for new installs by default now. For existing installs an update script should automatically enable it in config to keep bc.

Note: Once this has been merge we need to update the FAQ here https://matomo.org/faq/how-to/faq_30/ and maybe also some other places.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels Jun 11, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone Jun 11, 2021
@sgiehl sgiehl force-pushed the disablelogme branch 2 times, most recently from ea3f2b4 to acef8b4 Compare June 11, 2021 14:29
@diosmosis
Copy link
Member

@sgiehl should the developer changelog be updated? I'm thinking it would be helpful to both let users know they need to set it explicitly, and that it's recommended for existing installs to disable it since most won't need this functionality.

@sgiehl
Copy link
Member Author

sgiehl commented Jun 14, 2021

added a changelog entry

@diosmosis diosmosis merged commit 03410d6 into 4.x-dev Jun 14, 2021
@diosmosis diosmosis deleted the disablelogme branch June 14, 2021 20:46
@mattab
Copy link
Member

mattab commented Jul 26, 2021

@sgiehl Could you please document this in https://matomo.org/faq/how-to/faq_30/ as mentioned in the description? Thanks

@sgiehl
Copy link
Member Author

sgiehl commented Jul 28, 2021

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @diosmosis @mattab