@sgiehl opened this Pull Request on June 11th 2021 Member

Description:

Logme functionality will be disabled for new installs by default now. For existing installs an update script should automatically enable it in config to keep bc.

Note: Once this has been merge we need to update the FAQ here https://matomo.org/faq/how-to/faq_30/ and maybe also some other places.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on June 11th 2021 Member

@sgiehl should the developer changelog be updated? I'm thinking it would be helpful to both let users know they need to set it explicitly, and that it's recommended for existing installs to disable it since most won't need this functionality.

@sgiehl commented on June 14th 2021 Member

added a changelog entry

@mattab commented on July 26th 2021 Member

@sgiehl Could you please document this in https://matomo.org/faq/how-to/faq_30/ as mentioned in the description? Thanks

@sgiehl commented on July 28th 2021 Member

done

This Pull Request was closed on June 14th 2021
Powered by GitHub Issue Mirror