Ignore invalid capabilities instead of throwing an exception #17660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
reviewed
Jun 11, 2021
|
The change looks good 👍 but there are some tests failing. |
|
@diosmosis should be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When the database contains an access entry with an capability that is no longer present (e.g. TagManager capability, but TagManager gets disabled), the user admin currently does not show any users, but also no error.
The missing error is caused by the incorrect Piwik::translate, which actually triggers a warning. The error itself is caused by the exception thrown when a capability does not exist.
fixes L3-108
Review