Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove archive status locking since it is not needed anymore #17657

Merged
merged 2 commits into from Jun 10, 2021

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Jun 9, 2021

Description:

The status and ts_started columns in the archive_invalidation table provide the same functionality now so the extra overhead of acquiring and re-acquiring locks is no longer needed.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

…and ts_started columns in the archive_invalidation table.
@diosmosis diosmosis added this to the 4.4.0 milestone Jun 9, 2021
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine. Some tests needs to be updated

@diosmosis diosmosis merged commit 3a1467f into 4.x-dev Jun 10, 2021
@diosmosis diosmosis deleted the remove-archiving-lock branch June 10, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants