New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix insights widget "Others" percentage #17656
Conversation
code looks good 👍 |
Many thanks. I applied the new code, but I think I have to wait for the next report generation to see the results. Where is the new function |
Okay, it does not fix the issue in our case. I added the code, verified it, cleared all caches, but it still shows:
on all page title lists. Are there other companion changes required, committed outside of this PR? |
@MichaIng This by itself seemed to fix it for me locally (and the test works on this branch but fails on 4.x-dev). I'll reopen the original issue. |
@MichaIng could you post the following screenshots to help us debug?
|
@MichaIng I'll try to reproduce this again. Would you be willing to provide view access to your Matomo in the event I can't? |
Yes, I can do that. |
@MichaIng can you email dizzy@innocraft.com with access details? I'll take a closer look today. |
Okay that is strange, the issue seems to fade currently, while all I just did is updating another app. Is the "Others" entry preserved in reports and because of this still shown even that the code has been fixed? The very same time range the screenshot above is from now does not shot "Others" anymore, the "PAGE TITLES" section in the "Insights Overview" widget is gone completely instead. I still see "Others" when switching to "day" or "week" view (above is "date range", covering last seven days). But I'll send you access details regardless. |
It is preserved in reports, but the Insights report is not stored in the database. It's built dynamically using stored reports for the current period and previous period, for example, the page titles reports. So if the data in the periods for other reports (like the page titles reports) change, then the Insights reports should display different data immediately. I'm not sure why it would show nothing now... I'll take a look later and see what I can find. |
Resolved via email, the PR does work. |
Yes, many thanks. The entries from the old records basically needed to fade out. |
@diosmosis so we can close #17615 again? |
@sgiehl yes 👍. Closed it. |
Description:
fixes #17615
Review