code looks good :+1:
Many thanks. I applied the new code, but I think I have to wait for the next report generation to see the results.
Where is the new function
getPastRowFromCurrent actually used?
EDIT: Ah sorry, I see now it is an override.
Okay, it does not fix the issue in our case. I added the code, verified it, cleared all caches, but it still shows:
Others +100% Others -100%
on all page title lists.
Are there other companion changes required, committed outside of this PR?
@MichaIng This by itself seemed to fix it for me locally (and the test works on this branch but fails on 4.x-dev). I'll reopen the original issue.
@MichaIng could you post the following screenshots to help us debug?
The page titles report does not show "Others" at all, neither for the current period (this is one week), nor for any previous period, long or short.
@MichaIng I'll try to reproduce this again. Would you be willing to provide view access to your Matomo in the event I can't?
Yes, I can do that.
Okay that is strange, the issue seems to fade currently, while all I just did is updating another app. Is the "Others" entry preserved in reports and because of this still shown even that the code has been fixed? The very same time range the screenshot above is from now does not shot "Others" anymore, the "PAGE TITLES" section in the "Insights Overview" widget is gone completely instead. I still see "Others" when switching to "day" or "week" view (above is "date range", covering last seven days).
But I'll send you access details regardless.
Is the "Others" entry preserved in reports and because of this still shown even that the code has been fixed?
It is preserved in reports, but the Insights report is not stored in the database. It's built dynamically using stored reports for the current period and previous period, for example, the page titles reports. So if the data in the periods for other reports (like the page titles reports) change, then the Insights reports should display different data immediately. I'm not sure why it would show nothing now... I'll take a look later and see what I can find.
Resolved via email, the PR does work.
Yes, many thanks. The entries from the old records basically needed to fade out.