Fix redirect link not working after plugin activation #17654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported in https://forum.matomo.org/t/i-get-an-error-when-i-click-to-activate-the-plugin/42173/2
It turns out unlike the regular "activate plugin" buttons, the ones shown after uploading a plugin zip don't have a
redirectTo
GET parameter set.matomo/plugins/CorePluginsAdmin/templates/uploadPlugin.twig
Line 29 in 587cc39
This should not matter as an empty value means redirecting to the plugin or theme list (which is what we want.
matomo/plugins/CorePluginsAdmin/Controller.php
Lines 469 to 476 in 792bc0c
But #17345 added a section that reads the parameters, but forgot to set a default value for
redirectTo
in case it is missing, throwing the error reported on the forumReview