Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Diagnostics, fix edge case "Warning - trim() expects parameter 1 to be string, array given" #17653

Merged
merged 1 commit into from Jun 8, 2021
Merged

In Diagnostics, fix edge case "Warning - trim() expects parameter 1 to be string, array given" #17653

merged 1 commit into from Jun 8, 2021

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Jun 8, 2021 •
edited by Findus23

Description:

As title.

reported in https://forum.matomo.org/t/warning-required-private-directories/42158

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Jun 8, 2021
@diosmosis diosmosis added this to the 4.4.0 milestone Jun 8, 2021
@sgiehl sgiehl merged commit 8c746b9 into 4.x-dev Jun 8, 2021
@sgiehl sgiehl deleted the required-priv-directories-array branch June 8, 2021 19:26
@mattab mattab changed the title look in the data element since response is an array In Diagnostics, fix edge case "Warning - trim() expects parameter 1 to be string, array given" Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl