@Findus23 opened this Pull Request on June 4th 2021 Member

reported in https://forum.matomo.org/t/deprecated-uasort-returning-bool-from-comparison-function-is-deprecated-return-an-integer-less-than-equal-to-or-greater-than-zero-matomo-4-2-1/42125

core\Profiler.php(80): Deprecated - uasort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero

I didn't test this, but the fix seems obvious from https://www.php.net/manual/en/function.uasort.php

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on June 4th 2021
Powered by GitHub Issue Mirror