Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if table is falsey use null in compareTables() #17642

Merged
merged 1 commit into from Jun 9, 2021
Merged

if table is falsey use null in compareTables() #17642

merged 1 commit into from Jun 9, 2021

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis mentioned this pull request Jun 2, 2021
Closed
@sgiehl sgiehl linked an issue Jun 8, 2021 that may be closed by this pull request
ComparisonRowGenerator::compareTables() must implement interface Piwik\\DataTable\\DataTableInterface or be null, #17641
Closed
@diosmosis diosmosis merged commit 36e83dc into 4.x-dev Jun 9, 2021
@diosmosis diosmosis deleted the 17641-comparison-fix branch June 9, 2021 04:42
@diosmosis diosmosis added this to the 4.4.0 milestone Jun 9, 2021
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
3 participants
@diosmosis @sgiehl @mattab