Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple sizes of favicons #17638

Open
JE4GLE opened this issue May 28, 2021 · 2 comments
Open

Add multiple sizes of favicons #17638

JE4GLE opened this issue May 28, 2021 · 2 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
For Prioritization

Comments

@JE4GLE
Copy link
Contributor

JE4GLE commented May 28, 2021

Summary

The option to provide a favicon for the self-hosted matomo installation is very good, but it is still missing different favicon sizes to be displayed properly on every operating system. For example, I added my matomo link to my favorites in macOS and iOS, but it isn't using the favicon as an icon.
Generating different sizes for favicons would be a great improvement. See this site for an example of the different favicon sizes: https://www.favicon-generator.org
@JE4GLE JE4GLE added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label May 28, 2021
@Findus23
Copy link
Member

Hi,

I think nowadays every browser should support a simple single PNG file that is high resolution enough as a favicon and scale it to the size it needs.
I think the issue is just that Matomo resizes the favicon image to 32x32px on upload which might be a bit small.
I guess just increasing that number should improve the situation already a lot (especially as the default Matomo favicon is 256x256px)

matomo/plugins/CoreAdminHome/CustomLogo.php

Line 24 in 0dfdfe8

const FAVICON_HEIGHT = 32;

But one would also need to update the resizing logic below to never upscale icons.

@sgiehl
Copy link
Member

sgiehl commented May 31, 2021

Guess it makes sense to simply generate a bigger one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
4 participants
@sgiehl @Findus23 @JE4GLE @innocraft-automation