@diosmosis opened this Pull Request on May 28th 2021 Member

Description:

This change allows INI config sections like [Tracker_$idSite] to be added which will override some Tracker config for individual sites. Config that should be applied overall (or in places where we don't know what the idSite is), cannot be overridden.

Review

  • [x] Functional review done
  • [x] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done see checklist
  • [x] Code review done
  • [ ] Tests were added if useful/possible
  • [x] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [x] Documentation added if needed
  • [x] Existing documentation updated if needed
@tsteur commented on May 28th 2021 Member

@diosmosis added https://matomo.org/faq/how-to/how-do-i-configure-a-config-setting-in-the-config-ini-php-differently-for-a-specific-site/ and also added the logic for 3 more settings where this may be quite useful. Once tests pass it should be good to merge.

@tsteur commented on May 30th 2021 Member

@diosmosis a few tests seem to need fixing and then should be good to merge

This Pull Request was closed on May 31st 2021
Powered by GitHub Issue Mirror