Support for Tracker INI settings to be set for each website #17636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
force-pushed
the
l3-96-allow-disable-userid-overwrite
branch
from
f3c45dd
to
ad37df6
Compare
diosmosis
changed the title
tsteur
reviewed
May 28, 2021
core/Tracker/Response.php
Outdated
| @@ -25,7 +25,7 @@ public function init(Tracker $tracker) | |||
| { | |||
| ob_start(); // we use ob_start only because of Common::printDebug, we should actually not really use ob_start | |||
|
|
|||
| if ($tracker->isDebugModeEnabled() && TrackerConfig::getConfigValue('enable_sql_profiler')) { | |||
| if ($tracker->isDebugModeEnabled() && TrackerConfig::getConfigValue('enable_sql_profiler', $this->getIdSite())) { | |||
There was a problem hiding this comment.
fyi @diosmosis this method getIdSite doesn't seem to be defined?
There was a problem hiding this comment.
👍 this one doesn't need to be overridden
|
@diosmosis added https://matomo.org/faq/how-to/how-do-i-configure-a-config-setting-in-the-config-ini-php-differently-for-a-specific-site/ and also added the logic for 3 more settings where this may be quite useful. Once tests pass it should be good to merge. |
|
@diosmosis a few tests seem to need fixing and then should be good to merge |
mattab
changed the title
mattab
added
the
Enhancement
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change allows INI config sections like
[Tracker_$idSite]to be added which will override some Tracker config for individual sites. Config that should be applied overall (or in places where we don't know what the idSite is), cannot be overridden.Review