Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plugins to abort sending emails via 'Mail.send' event #17635

Merged
merged 3 commits into from May 30, 2021
Merged

Allow plugins to abort sending emails via 'Mail.send' event #17635

merged 3 commits into from May 30, 2021

Conversation

diosmosis
Copy link
Member

Description:

Refs DEV-2158

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 28, 2021
@diosmosis diosmosis added this to the 4.4.0 milestone May 28, 2021
@sgiehl
Copy link
Member

sgiehl commented May 28, 2021

@diosmosis Is it worth having a test for that? If not it should be good to merge.

@diosmosis diosmosis merged commit 30eec94 into 4.x-dev May 30, 2021
@diosmosis diosmosis deleted the allow-abort-mail branch May 30, 2021 19:21
@mattab mattab changed the title Allow aborting sending mails via Mail.send event. Allow plugins to abort sending emails via 'Mail.send' event Jul 27, 2021
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @mattab