Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalidate-report-data console to show a timestamp in the output #17633

Merged
merged 2 commits into from May 28, 2021
Merged

invalidate-report-data console to show a timestamp in the output #17633

merged 2 commits into from May 28, 2021

Conversation

diosmosis
Copy link
Member

…timestamp in the output

As requested by support

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis
Use logger when outputting invalidate-report-data so there will be a …
7e752e1 
…timestamp in the output

As requested by support
@diosmosis diosmosis added the Needs Review PRs that need a code review label May 27, 2021
@diosmosis diosmosis added this to the 4.4.0 milestone May 27, 2021
flamisz
flamisz approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@flamisz flamisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@diosmosis diosmosis merged commit 1437f28 into 4.x-dev May 28, 2021
@diosmosis diosmosis deleted the invalidate-report-data-logger branch May 28, 2021 01:24
@mattab mattab changed the title Use logger when outputting invalidate-report-data so there will be a … invalidate-report-data console to show a timestamp in the output Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamisz flamisz flamisz approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @flamisz