Improve purge log data logic to improve speed, and avoid locks in some cases #17632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
see https://stackoverflow.com/questions/23193761/delete-operation-locks-whole-table-in-innodb/23194154
Deletes may be faster or less locking when they are in descending order. Also added a transaction uncommitted in the hope for this to be less locking and making it faster. This should be fine because we usually delete only older visits anyway and they wouldn't be included in current reports or something.
Problem was that we noticed some locks around the time when the delete visits statement ran even though InnoDB was used.
Review