Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Rows to display" cannot be changed if a row is expanded #17628

Closed
Starker3 opened this issue May 27, 2021 · 8 comments · Fixed by #17704
Closed

"Rows to display" cannot be changed if a row is expanded #17628

Starker3 opened this issue May 27, 2021 · 8 comments · Fixed by #17704
Assignees
@justinvelluppillai
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.

Comments

@Starker3
Copy link
Contributor

Expected Behavior

We would expect that a reports maximum "Rows to display" can be changed when expanding/collapsing a row in the report.

Current Behavior

Currently when a report contains rows that can be expanded (When a report is hierarchical), the option to change the maximum number of rows is removed. For example when no rows are expanded the option to change the number of rows is shown:
Thursday-27-05-2021 14-53-42

However, when one of the rows has been expanded, the option is removed:

Thursday-27-05-2021 14-54-02

The option does not show again, even after the row is collapsed and requires a page refresh to show the option again:
Thursday-27-05-2021 14-54-20

Possible Solution

Allow the "Rows to display" to be changed when a row is expanded in a hierarchical report, or alternatively we can continue to show the number of "Rows to display" and perhaps disable the option to click on it and change it (Maybe by greying it out on the page or removing the dropdown arrow to show it cannot be changed)
This will at least show users what the current maximum number of rows is for the report they are viewing.

Your Environment

  • Matomo Version: 4.3.1
  • Browser: Firefox
  • Operating System: Ubuntu
@Starker3 Starker3 added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label May 27, 2021
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 27, 2021
@heurteph-ei
Copy link

Additional question in order to find the best solution: When roots are collapsed, does this number of rows selector filter the number of root rows, or the number of all rows including leaves?
If this only apply on the roots, so the selector could be displayed and be active all time...

@Starker3
Copy link
Contributor Author

@heurteph-ei It affects all row limits for the report including subtable rows.
So for example is we set the limit to 10, the root row including all subtable rows will each be limited to 10.

That means that technically you could see all the top rows if your limit was for example 10, but if you expanded one row and the subtable had more than 10 rows in it you wouldn't see more than the first 10 rows of the expanded root row (For each level as well).

@diosmosis
Copy link
Member

@Starker3 noticed this as well and just created a bug report for it: #17634

@heurteph-ei
Copy link

So this bug seems easy to fix as the drop-box already works as expected, it has just to not be hidden...
But bug #17634 needs more work to be fixed...

@DontPlayTheGame
Copy link

DontPlayTheGame commented May 28, 2021 •
edited

I'm happy that the current behavior is now reported/labelled as bug.
Just my 2 cents to the issue (as some one as a CPUX) and with many feedback from our users, i can tell that the current behavior is not what a user is expecting during interactions with the UI.
The typical user interaction is:

  • select a date / date range,
  • check the numbers in the aggregated rows and
  • then click on a row to expand it to see further details

At this point the drop-down disappear and the user is wonder, why there are so few rows in the view (default is 10) and then i got a message "how can i/we see more data in the rows?" ;-) )

@tsteur
Copy link
Member

tsteur commented May 30, 2021

This seems to mostly impact action data tables where we show the subtable "embedded".

I see this was removed in 0b5e89c#diff-f1627c29aeaa3c345fe9c1cadcd5080c98fc169131e2e37a7d590bc7aa929532R240 and partially related 681d443

@sgiehl @mattab do you maybe remember why this was the case? I suppose it was only meant to apply to the subtable itself but not the rootTable and is simply a bug.

@tsteur tsteur added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels May 30, 2021
@sgiehl
Copy link
Member

sgiehl commented May 31, 2021

@tsteur can't remember actually. Maybe it was a usability thing. As changing the limit with an open subtable would actually close the subtable again and not show more rows in the subtable.

@tsteur
Copy link
Member

tsteur commented Jun 22, 2021

OK lets allow changing the value of rows to show even when there is a subtable open. If this becomes an issue then we can revert the change again later.

@justinvelluppillai justinvelluppillai self-assigned this Jun 23, 2021
@justinvelluppillai justinvelluppillai mentioned this issue Jun 24, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinvelluppillai justinvelluppillai

Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow changing row limit when hierarchy is expanded matomo-org/matomo
7 participants
@diosmosis @tsteur @justinvelluppillai @sgiehl @Starker3 @DontPlayTheGame @heurteph-ei