Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update matomo/cache to new version w/ doctrine/cache fork. #17623

Merged
merged 1 commit into from May 26, 2021
Merged

Update matomo/cache to new version w/ doctrine/cache fork. #17623

merged 1 commit into from May 26, 2021

Conversation

diosmosis
Copy link
Member

Description:

Uses our custom fork.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 26, 2021
@diosmosis diosmosis added this to the 4.4.0 milestone May 26, 2021
sgiehl
sgiehl approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sgiehl sgiehl removed the Needs Review PRs that need a code review label May 26, 2021
@diosmosis diosmosis merged commit 30583c7 into 4.x-dev May 26, 2021
@diosmosis diosmosis deleted the update-component-cache branch May 26, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl