clear EventDispatcher cache in tests #17620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Tests & QA
diosmosis
reviewed
May 25, 2021
| @@ -92,6 +93,7 @@ public function setUp(): void | |||
|
|
|||
| PiwikCache::getEagerCache()->flushAll(); | |||
| PiwikCache::getTransientCache()->flushAll(); | |||
| EventDispatcher::getInstance()->clearCache(); | |||
There was a problem hiding this comment.
Can we put this in Fixture::clearInMemoryCaches()?
There was a problem hiding this comment.
I see we call that in tearDown only for some reason... seems like a mistake, and we should clear all of those caches here too...
There was a problem hiding this comment.
@diosmosis updated the PR
There was a problem hiding this comment.
@diosmosis seems clearing all caches at this point lets various integration tests start failing. Seems clearing all static instances is a problem at that point as some fixtures are manipulating those before.
There was a problem hiding this comment.
Reverted it so it only adds the additional cache clear, but left a note so it's clear why not all caches are cleared
sgiehl
force-pushed
the
cleareventcache
branch
2 times, most recently
from
4481fe3
to
6b7c677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Was writing some tests that require the ActivityLog plugin but failed to get them working. The reason actually was, that the ActivityLog plugin dynamically tries to register hooks. To get that working in tests it's required to clear the registered hooks that might have been cached previously.
Review