@anonymous-matomo-user opened this Issue on October 12th 2010

Currently, piwik explicitely forbid use of "@" in a user login. (only [a-zA-Z0-9-._] are allowed )

It doesn't make much sense to forbid the "@" and it make it impossible to integrate piwik with any service where the login is the email (such as lot of LDAP setup).

@anonymous-matomo-user commented on October 12th 2010

Fixing this bug is really easy :

core/Piwik.php, line 1595

replace:

&& (pregmatch('/^[A-Za-z0-9.-]*$/', $userLogin) > 0))

By

&& (pregmatch('/^[@A-Za-z0-9.-]*$/', $userLogin) > 0))

@anonymous-matomo-user commented on October 12th 2010

(I've tested it and it works great)

@robocoder commented on October 12th 2010 Contributor

re: LDAP. Is this change necessary, given the LDAP plugin in #734?

@anonymous-matomo-user commented on October 12th 2010

I guess it is because it looks like the http_auth plugin is more interesting anyway. Ldap is only use to do authentification, piwik still do the authorization.

Comments in the bug related to the http_auth plugin seems to think the same;-)

@mattab commented on November 16th 2010 Member

increasing priority, as it makes sense to allow @ in logins

@mattab commented on November 29th 2010 Member

(In [3381]) Fixes #1762

@robocoder commented on November 30th 2010 Contributor

(In [3388]) refs #1762 - fix unit test

@robocoder commented on January 6th 2011 Contributor

(In [3646]) fixes #1970, refs #1762 - add more unit tests

This Issue was closed on January 6th 2011
Powered by GitHub Issue Mirror