Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matomo reports file integrity issue for stray files after upgrade #17619

Open
alimony opened this issue May 25, 2021 · 4 comments
Open

Matomo reports file integrity issue for stray files after upgrade #17619

alimony opened this issue May 25, 2021 · 4 comments
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Milestone
For Prioritization

Comments

@alimony
Copy link

alimony commented May 25, 2021

Expected Behavior

Upgrading Matomo should not introduce any stray files that cause a file integrity check warning.

Current Behavior

File integrity check reports the following after upgrading:

Files were found in your Matomo, but we didn't expect them.
--> Please delete these files to prevent errors. <--

File to delete: package-lock.json
File to delete: phpcs.xml

Possible Solution

Not sure.

Steps to Reproduce (for Bugs)

  1. Upgrade Matomo to 4.3.0
  2. Run the system check

Context

Does not affect me directly, but something is obviously wrong.

Your Environment

  • Matomo Version: 4.3.0
  • PHP Version: 7.4.3
  • Server Operating System: Ubuntu 20.04.1 LTS
  • Additionally installed plugins: GoogleAnalyticsImporter, InvalidateReports, TasksTimetable
@alimony alimony added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label May 25, 2021
@Findus23
Copy link
Member

Hi,
this is related to #17399

Simply automatically deleting all files that the integrity report flags sounds like a very bad idea as it will probably delete custom files from a few users.
So a more clever solution needs to be found.

@alimony
Copy link
Author

alimony commented May 25, 2021

I don't expect Matomo itself to leave these specific files behind in the first place.

@sgiehl
Copy link
Member

sgiehl commented May 25, 2021

Those files should not have been included in a release at all. That was kind of done by accident and so they have been removed in a later release again.

@math-GH
Copy link

math-GH commented May 26, 2021

I had the same issue. It needed some minutes, than the issue disappeared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
5 participants
@alimony @sgiehl @math-GH @Findus23 @innocraft-automation