Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncaught exception when running system tests for plugins #17618

Merged
merged 2 commits into from May 25, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 25, 2021

Description:

When running system tests for plugins there is currently an uncaught exception when the tests starts running.
See eg. https://travis-ci.com/github/matomo-org/matomo/jobs/507308739#L732

This is caused by a dataprovider that tries to fetch available segments before the database is actually set up. As the visitor id segment tries to check for a system settings this fails.

This actually caused the AutoSuggestAPI test not to run anymore

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 25, 2021
@sgiehl sgiehl added this to the 4.3.1 milestone May 25, 2021
@diosmosis
Copy link
Member

👍

@diosmosis diosmosis merged commit dd744fe into 4.x-dev May 25, 2021
@diosmosis diosmosis deleted the fixtestissue branch May 25, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants