Make sure that all segment archives are invalidated when invalidating all visits archives #17617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validation table, when invalidating normal archives
diosmosis
added
Bug
flamisz
approved these changes
May 30, 2021
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When we invalidate an All Visits archive (
segment = '') we also invalidate all segment archives for the same site and period. This is because if the data for the main archive needs to be recomputed, then the segment archives may need to be recomputed as well.Any archive that is invalidated needs to also show up in the archive_invalidations table. However, currently, we are not inserting the extra segment archives into that table. This is fixed by this PR.
Review