Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2-lines label overflows the input #17602

Closed
math-GH opened this issue May 20, 2021 · 1 comment · Fixed by #18052
Closed

Fix 2-lines label overflows the input #17602

math-GH opened this issue May 20, 2021 · 1 comment · Fixed by #18052
Assignees
@peterhashair
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.6.0

Comments

@math-GH
Copy link

math-GH commented May 20, 2021

Bildschirmfoto 2021-05-20 um 15 35 40

link: /index.php?module=CoreAdminHome&action=generalSettings&idSite=1&period=year&date=today

In English it is mostly quite ok, because the texts are short.
In German it happens often, because of longer texts.

Expected Behavior

more whitespace between label and input

Current Behavior

less whitespace

Possible Solution

CSS: less "line-height" (f.e. 1em)

better:
I do not understand why the label follows after the input in HTML.
grafik

Better would be: first the label, then the input.

The label could be display: block, so it would not overflow the input.

Steps to Reproduce (for Bugs)

see screen shots

Your Environment

  • Matomo Version: matomo.cloud
  • Browser: Firefox 88
  • Operating System: MacOS
@math-GH math-GH added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label May 20, 2021
@diosmosis
Copy link
Member

Thanks for the bug report @mathContao, there certainly could be more space in this situation!

@diosmosis diosmosis added c: Design / UI For issues that impact Matomo's user interface or the design overall. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 20, 2021
@tsteur tsteur added this to the Priority Backlog (Help wanted) milestone May 20, 2021
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label May 20, 2021
@peterhashair peterhashair self-assigned this Sep 23, 2021
@peterhashair peterhashair linked a pull request Sep 23, 2021 that will close this issue
2-lines label overflows the input on small device #18052
Merged
11 tasks
@peterhashair peterhashair mentioned this issue Oct 4, 2021
Merged
11 tasks
@justinvelluppillai justinvelluppillai changed the title 2-lines label overflows the input Fix 2-lines label overflows the input Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

2-lines label overflows the input on small device matomo-org/matomo
5 participants
@diosmosis @tsteur @justinvelluppillai @math-GH @peterhashair