Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing iso attributes to Greece map #17593

Merged
merged 1 commit into from May 19, 2021
Merged

Adds missing iso attributes to Greece map #17593

merged 1 commit into from May 19, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 19, 2021

Description:

Seems the regions of Greece were almost the same within FIPS, so I've added the data-p attributes with the ISO codes, so the regions can be correctly highlighted

fixes #17590

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 19, 2021
@sgiehl sgiehl added this to the 4.3.1 milestone May 19, 2021
@diosmosis diosmosis merged commit d099f75 into 4.x-dev May 19, 2021
@diosmosis diosmosis deleted the fixgrmap branch May 19, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.1
Development

Successfully merging this pull request may close these issues.

Visitor Map shows no visits for all regions of Greece (matomo 4.2.1/geoip2 lite)
2 participants
@sgiehl @diosmosis