Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DE-Translation missed, when website was updated #17591

Closed
math-GH opened this issue May 19, 2021 · 3 comments · Fixed by #17673
Closed

DE-Translation missed, when website was updated #17591

math-GH opened this issue May 19, 2021 · 3 comments · Fixed by #17673
Assignees
@justinvelluppillai
Labels
c: i18n For issues around internationalisation and localisation. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.5.0

Comments

@math-GH
Copy link

math-GH commented May 19, 2021

grafik

User interface language: German

What I did:
Changed some settings of a website

Expected Behavior

OK-Message in German (f.e. "Website wurde aktualisiert")

Current Behavior

OK message in English

Possible Solution

translation added

Steps to Reproduce (for Bugs)

  1. Go to matomo.cloud/index.php?module=SitesManager&action=index&idSite=1&period=year&date=today
  2. edit page seetings
  3. save it

Context

German user interface

Your Environment

  • Matomo Version: matomo.cloud
@math-GH math-GH added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label May 19, 2021
@Findus23
Copy link
Member

Seems like this text is indeed not translatable yet:

matomo/plugins/SitesManager/angularjs/sites-manager/sites-manager-site.controller.js

Lines 141 to 144 in bf38fde

var message = 'Website updated';
if (isNewSite) {
message = 'Website created';
}

@Findus23 Findus23 added c: i18n For issues around internationalisation and localisation. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 19, 2021
@sgiehl
Copy link
Member

sgiehl commented May 19, 2021

Thanks @mathContao for creating the issue.
Putting into current milestone as it should be fixable in a couple of minutes.

@sgiehl sgiehl added this to the 4.3.1 milestone May 19, 2021
@tsteur tsteur modified the milestones: 4.3.1, 4.4.0 May 20, 2021
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label May 20, 2021
@justinvelluppillai justinvelluppillai self-assigned this Jun 14, 2021
@Findus23
Copy link
Member

This got fixed by #17673, right @justinvelluppillai?

@Findus23 Findus23 linked a pull request Jun 14, 2021 that will close this issue
Removing hardcoded strings and adding new translation strings for "We… #17673
Merged
10 tasks
@mattab mattab modified the milestones: 4.6.0, 4.5.0 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinvelluppillai justinvelluppillai

Labels
c: i18n For issues around internationalisation and localisation. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

Removing hardcoded strings and adding new translation strings for "We… matomo-org/matomo
6 participants
@tsteur @mattab @justinvelluppillai @sgiehl @math-GH @Findus23