Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use html formatter for formating reported generated #17588

Merged
merged 1 commit into from May 20, 2021
Merged

Use html formatter for formating reported generated #17588

merged 1 commit into from May 20, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented May 19, 2021

Description:

fixes #17567

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this May 19, 2021
@flamisz flamisz added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels May 19, 2021
@flamisz flamisz added this to the 4.3.0 milestone May 19, 2021
@sgiehl sgiehl modified the milestones: 4.3.0, 4.3.1 May 19, 2021
sgiehl
sgiehl approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Not sure if it would be worth to add a UI test for it. If so guess the code would need to be changed to use Date class instead of the time functions, so it's possible to fake the now timestamp.

@tsteur tsteur merged commit 5d9cf64 into 4.x-dev May 20, 2021
@tsteur tsteur deleted the 17567-report-generated-time branch May 20, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@flamisz flamisz

Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.1
Development

Successfully merging this pull request may close these issues.

report information: "Report generated" without time unit (seconds?)
3 participants
@flamisz @sgiehl @tsteur