Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload logo form fix #17587

Merged
merged 1 commit into from May 19, 2021
Merged

Upload logo form fix #17587

merged 1 commit into from May 19, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented May 18, 2021 •
edited by sgiehl

Description:

fixes #17586

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this May 18, 2021
@flamisz flamisz added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 18, 2021
@flamisz flamisz added this to the 4.3.1 milestone May 18, 2021
@sgiehl sgiehl removed the Needs Review PRs that need a code review label May 19, 2021
@sgiehl sgiehl merged commit 1cbb7ab into 4.x-dev May 19, 2021
@sgiehl sgiehl deleted the w17586 branch May 19, 2021 08:16
@tsteur tsteur mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@flamisz flamisz

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.1
Development

Successfully merging this pull request may close these issues.

Uploading logo kicks user out
2 participants
@flamisz @sgiehl