Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Check showing warning when max_execution_time is set to -1 in PHP.ini #17585

Closed
Starker3 opened this issue May 18, 2021 · 2 comments · Fixed by #17684
Closed

System Check showing warning when max_execution_time is set to -1 in PHP.ini #17585

Starker3 opened this issue May 18, 2021 · 2 comments · Fixed by #17684
Assignees
@justinvelluppillai
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.5.0

Comments

@Starker3
Copy link
Contributor

Starker3 commented May 18, 2021 •
edited

Current Behavior

Some systems seem to not support setting max_execution_time=0, in these cases setting max_execution_time=-1 seems to work to disable the max execution time

However, this causes a warning in the System Check:
image

Possible Solution

Add check for max_execution_time=-1

Your Environment

  • Matomo Version: 4.2.1
  • PHP Version: 7.4.18
  • Server Operating System: Ubuntu
  • Additionally installed plugins: NA
@Starker3 Starker3 added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label May 18, 2021
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 19, 2021
@tsteur tsteur added this to the 4.5.0 milestone May 19, 2021
@tsteur
Copy link
Member

tsteur commented May 19, 2021

I'll move it in a milestone simply because it's very quick to do. Setting it to 0 should always work though. When setting it to -1 seems you actually simply set a very high number see https://stackoverflow.com/a/9371428

@Starker3
Copy link
Contributor Author

Setting it to 0 seems to work in >99% of the cases.
We did get two reports from two different users, one got the result:
{"result": "error","message": "Maximum execution time of 0 seconds exceeded"}

Another one had a fatal PHP error with PHP 7.4.16:
PHP Fatal error: Maximum execution time of 0 seconds exceeded in /srv/http/piwik

@justinvelluppillai justinvelluppillai self-assigned this Jun 17, 2021
justinvelluppillai added a commit that referenced this issue Jun 17, 2021
@justinvelluppillai
Add check for setting max_execution_time = -1, see #17585
62e9483
@sgiehl sgiehl linked a pull request Jun 17, 2021 that will close this issue
Add check for setting max_execution_time = -1, see #17585 #17684
Merged
10 tasks
sgiehl added a commit that referenced this issue Jun 17, 2021
@justinvelluppillai @sgiehl
Add check for setting max_execution_time = -1, see #17585 (#17684)
0c38597 
* Add check for setting max_execution_time = -1, see #17585

* updates expected screenshots

Co-authored-by: sgiehl <stefan@matomo.org>
@mattab mattab modified the milestones: 4.7.0, 4.5.0 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinvelluppillai justinvelluppillai

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

Add check for setting max_execution_time = -1, see #17585 matomo-org/matomo
4 participants
@tsteur @mattab @justinvelluppillai @Starker3